Merge pull request 'removed logic for skipping in remark import' (#237 ) from ranjith-dev into master

Reviewed-on: #237
removed logic for skipping in remark import
2026-01-23 06:38:34 +00:00 · 2026-01-23 12:08:10 +05:30
2 changed files with 5 additions and 7 deletions
--- a/app/Filament/Pages/InvoicePendingReason.php
+++ b/app/Filament/Pages/InvoicePendingReason.php
@@ -340,6 +340,7 @@ class InvoicePendingReason extends Page
                    ->send();
                $this->filtersForm->fill([
                    'file' => null,
+                    'plant_id' => $plantId,
                ]);
                return;
            }
@@ -352,6 +353,7 @@ class InvoicePendingReason extends Page
                    ->send();
                $this->filtersForm->fill([
                    'file' => null,
+                    'plant_id' => $plantId,
                ]);
                return;
            }
@@ -383,6 +385,7 @@ class InvoicePendingReason extends Page
                    ->send();
                $this->filtersForm->fill([
                    'file' => null,
+                    'plant_id' => $plantId,
                ]);
                return;
            }
@@ -395,6 +398,7 @@ class InvoicePendingReason extends Page
                    ->send();
                $this->filtersForm->fill([
                    'file' => null,
+                    'plant_id' => $plantId,
                ]);
                return;
            }
@@ -407,6 +411,7 @@ class InvoicePendingReason extends Page
                    ->send();
                $this->filtersForm->fill([
                    'file' => null,
+                    'plant_id' => $plantId,
                ]);
                return;
            }
--- a/app/Imports/InvoicePendingReasonImport.php
+++ b/app/Imports/InvoicePendingReasonImport.php
@@ -72,13 +72,6 @@ class InvoicePendingReasonImport implements ToCollection
                ];
                continue;
            }
-            else if (! $remark) {
-                $this->remarkEmpty[] = [
-                    'row' => $rowNo,
-                    'reason' => "Remark can't be empty!",
-                ];
-                continue;
-            }

            //Excel-level duplicate check
            $key = $plantCode . '|' . $documentNumber;
Author	SHA1	Message	Date
jothi	379e8fc8f9	Merge pull request 'removed logic for skipping in remark import' (#237 ) from ranjith-dev into master All checks were successful Scan for leaked secrets using Kingfisher / kingfisher-secrets-scan (push) Successful in 14s Details Reviewed-on: #237	2026-01-23 06:38:34 +00:00
dhanabalan	fff610bc2e	removed logic for skipping in remark import Some checks failed Scan for leaked secrets using Kingfisher / kingfisher-secrets-scan (push) Successful in 12s Details Scan for leaked secrets using Kingfisher / kingfisher-secrets-scan (pull_request) Successful in 13s Details Gemini PR Review / Gemini PR Review (pull_request) Failing after 20s Details Laravel Larastan / larastan (pull_request) Failing after 3m45s Details Laravel Pint / pint (pull_request) Successful in 3m42s Details	2026-01-23 12:08:10 +05:30