Merge pull request 'removed logic for skipping in remark import' (#237) from ranjith-dev into master
All checks were successful
Scan for leaked secrets using Kingfisher / kingfisher-secrets-scan (push) Successful in 14s

Reviewed-on: #237
This commit was merged in pull request #237.
This commit is contained in:
2026-01-23 06:38:34 +00:00
2 changed files with 5 additions and 7 deletions

View File

@@ -340,6 +340,7 @@ class InvoicePendingReason extends Page
->send();
$this->filtersForm->fill([
'file' => null,
'plant_id' => $plantId,
]);
return;
}
@@ -352,6 +353,7 @@ class InvoicePendingReason extends Page
->send();
$this->filtersForm->fill([
'file' => null,
'plant_id' => $plantId,
]);
return;
}
@@ -383,6 +385,7 @@ class InvoicePendingReason extends Page
->send();
$this->filtersForm->fill([
'file' => null,
'plant_id' => $plantId,
]);
return;
}
@@ -395,6 +398,7 @@ class InvoicePendingReason extends Page
->send();
$this->filtersForm->fill([
'file' => null,
'plant_id' => $plantId,
]);
return;
}
@@ -407,6 +411,7 @@ class InvoicePendingReason extends Page
->send();
$this->filtersForm->fill([
'file' => null,
'plant_id' => $plantId,
]);
return;
}

View File

@@ -72,13 +72,6 @@ class InvoicePendingReasonImport implements ToCollection
];
continue;
}
else if (! $remark) {
$this->remarkEmpty[] = [
'row' => $rowNo,
'reason' => "Remark can't be empty!",
];
continue;
}
//Excel-level duplicate check
$key = $plantCode . '|' . $documentNumber;