poc/pds
1
0
Fork 1
Code Issues Pull Requests 8 Actions Packages Projects Releases Wiki Activity

Refactor readFiles method to enhance CSV row validation and ensure unique remaining rows are collected

Browse Source
This commit is contained in:
dhanabalan
2025-09-26 11:49:31 +05:30
parent bbe05d62b1
commit 9774cda2ad
1 changed files with 30 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
app/Http/Controllers/SapFileController.php
View File

@@ -183,14 +183,15 @@ class SapFileController extends Controller
$serialNumbers = []; $serialNumbers = [];
$remainingRows = []; $remainingRows = [];
foreach ($lines as $line) { foreach ($lines as $line)
{
$values = str_getcsv($line); $values = str_getcsv($line);
// Debug: make sure CSV split is correct // Debug: make sure CSV split is correct
if (count($values) < 6) { if (count($values) < 6) {
return response()->json([ return response()->json([
'status' => 'ERROR', 'status' => 'ERROR',
'message' => 'CSV row has fewer than 6 columns', 'message' => 'In text file has fewer than 6 columns',
'line' => $line 'line' => $line
], 400); ], 400);
} }
@@ -199,15 +200,21 @@ class SapFileController extends Controller
$remainingRow = $values; $remainingRow = $values;
unset($remainingRow[5]); unset($remainingRow[5]);
// $remainingRow = array_values($remainingRow); // reindex
// $remainingRows[] = $remainingRow;
$remainingRow = array_values($remainingRow); // reindex $remainingRow = array_values($remainingRow); // reindex
$remainingRows[] = $remainingRow;
}
return response()->json([ // Only add unique remaining rows
if (!in_array($remainingRow, $remainingRows, true)) {
$remainingRows[] = $remainingRow;
}
}
return response()->json([
'status' => 'SUCCESS', 'status' => 'SUCCESS',
'serial_numbers' => $serialNumbers, 'serial_numbers' => $serialNumbers,
'remaining_rows_sample' => array_slice($remainingRows, 0, 5), // just first 5 for debug 'remaining_rows_sample' => array_slice($remainingRows, 0, 5), // just first 5 for debug
]); ]);
} }