Refactor readFiles method to enhance CSV row validation and ensure unique remaining rows are collected

This commit is contained in:
dhanabalan
2025-09-26 11:49:31 +05:30
parent bbe05d62b1
commit 9774cda2ad

View File

@@ -183,31 +183,38 @@ class SapFileController extends Controller
$serialNumbers = [];
$remainingRows = [];
foreach ($lines as $line) {
$values = str_getcsv($line);
foreach ($lines as $line)
{
$values = str_getcsv($line);
// Debug: make sure CSV split is correct
if (count($values) < 6) {
return response()->json([
'status' => 'ERROR',
'message' => 'In text file has fewer than 6 columns',
'line' => $line
], 400);
}
$serialNumbers[] = $values[5] ?? null;
$remainingRow = $values;
unset($remainingRow[5]);
// $remainingRow = array_values($remainingRow); // reindex
// $remainingRows[] = $remainingRow;
$remainingRow = array_values($remainingRow); // reindex
// Only add unique remaining rows
if (!in_array($remainingRow, $remainingRows, true)) {
$remainingRows[] = $remainingRow;
}
}
// Debug: make sure CSV split is correct
if (count($values) < 6) {
return response()->json([
'status' => 'ERROR',
'message' => 'CSV row has fewer than 6 columns',
'line' => $line
], 400);
}
$serialNumbers[] = $values[5] ?? null;
$remainingRow = $values;
unset($remainingRow[5]);
$remainingRow = array_values($remainingRow); // reindex
$remainingRows[] = $remainingRow;
}
return response()->json([
'status' => 'SUCCESS',
'serial_numbers' => $serialNumbers,
'remaining_rows_sample' => array_slice($remainingRows, 0, 5), // just first 5 for debug
]);
'status' => 'SUCCESS',
'serial_numbers' => $serialNumbers,
'remaining_rows_sample' => array_slice($remainingRows, 0, 5), // just first 5 for debug
]);
}