Merge pull request 'removed required option in alert mail for schedule type' (#61) from ranjith-dev into master

Reviewed-on: #61

.github/workflows/gemini-pr-review.yaml

@@ -36,8 +36,8 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-npm-global-
 
-      - name: Install Gemini CLI globally
-        run: npm install -g --loglevel=http @google/gemini-cli
+#      - name: Install Gemini CLI globally
+#        run: npm install -g --loglevel=http @google/gemini-cli
 
       - name: Generate git diff and review with Gemini
         id: review

app/Console/Commands/Scheduler.php

@@ -0,0 +1,202 @@
+<?php
+
+namespace App\Console\Commands;
+
+use Illuminate\Console\Command;
+use Illuminate\Console\Scheduling\Schedule;
+use App\Models\AlertMailRule;
+use Illuminate\Support\Facades\Artisan;
+use Illuminate\Support\Facades\Log;
+
+class Scheduler extends Command
+{
+    /**
+     * The name and signature of the console command.
+     *
+     * @var string
+     */
+    // protected $signature = 'app:scheduler';
+
+    protected $signature = 'custom:scheduler';
+
+    /**
+     * The console command description.
+     *
+     * @var string
+     */
+    // protected $description = 'Command description';
+
+    protected $description = 'Manually trigger scheduler logic';
+
+    /**
+     * Execute the console command.
+     */
+    // public function handle()
+    // {
+    //     //
+    // }
+
+    public function handle()
+    {
+
+        // --- Production Rules ---
+        $productionRules = AlertMailRule::where('module', 'ProductionQuantities')
+            ->where('rule_name', 'ProductionMail')
+            ->select('plant', 'schedule_type')
+            ->distinct()
+            ->get();
+
+        foreach ($productionRules as $rule) {
+            switch ($rule->schedule_type) {
+                case 'Live':
+                    // Run every minute
+                    \Artisan::call('send:production-report', [
+                        'schedule_type' => $rule->schedule_type,
+                        'plant' => $rule->plant,
+                    ]);
+                    break;
+                case 'Hourly':
+                    if (now()->minute == 0) {
+                        \Artisan::call('send:production-report', [
+                            'schedule_type' => $rule->schedule_type,
+                            'plant' => $rule->plant,
+                        ]);
+                    }
+                    break;
+                case 'Daily':
+                    if (now()->format('H:i') == '07:59') {
+                        \Artisan::call('send:production-report', [
+                            'schedule_type' => $rule->schedule_type,
+                            'plant' => $rule->plant,
+                        ]);
+                    }
+                    break;
+            }
+        }
+
+
+        // --- Invoice Validation Rules ---
+        $invoiceRules = AlertMailRule::where('module', 'InvoiceValidation')
+            ->where('rule_name', 'InvoiceMail')
+            ->select('plant', 'schedule_type')
+            ->distinct()
+            ->get();
+
+        foreach ($invoiceRules as $rule) {
+
+            switch ($rule->schedule_type) {
+                case 'Live':
+                    // Run every minute
+                    \Artisan::call('send:invoice-report', [
+                        'schedule_type' => $rule->schedule_type,
+                        'plant' => $rule->plant,
+                    ]);
+                    break;
+
+                case 'Hourly':
+                    if (now()->minute == 0) {
+                        \Artisan::call('send:invoice-report', [
+                            'schedule_type' => $rule->schedule_type,
+                            'plant' => $rule->plant,
+                        ]);
+                    }
+                    break;
+                case 'Daily':
+                    if (now()->format('H:i') == '07:59') {
+                        \Artisan::call('send:invoice-report', [
+                            'schedule_type' => $rule->schedule_type,
+                            'plant' => $rule->plant,
+                        ]);
+                    }
+                    break;
+            }
+        }
+        // foreach ($invoiceRules as $rule) {
+
+        //     switch ($rule->schedule_type) {
+        //         case 'Live':
+        //             try {
+        //                 Artisan::call('send:invoice-report', [
+        //                     'schedule_type' => $rule->schedule_type,
+        //                     'plant' => $rule->plant,
+        //                 ]);
+
+        //                 Log::info('Invoice report sent | Plant: '.$rule->plant);
+        //             } catch (\Throwable $e) {
+        //                 Log::error("Invoice Live Failed ({$rule->plant}): ".$e->getMessage());
+        //             }
+        //             break;
+
+        //         case 'Hourly':
+        //             if (now()->minute == 0) {
+        //                 Artisan::call('send:invoice-report', [
+        //                     'schedule_type' => $rule->schedule_type,
+        //                     'plant' => $rule->plant,
+        //                 ]);
+        //             }
+        //             break;
+
+        //         case 'Daily':
+        //             if (now()->format('H:i') == '07:59') {
+        //                 Artisan::call('send:invoice-report', [
+        //                     'schedule_type' => $rule->schedule_type,
+        //                     'plant' => $rule->plant,
+        //                 ]);
+        //             }
+        //             break;
+        //     }
+        // }
+
+
+        // --- Invoice Data Report Rules ---
+        $invoiceDataRules = AlertMailRule::where('module', 'InvoiceDataReport')
+            ->where('rule_name', 'InvoiceDataMail')
+            ->select('plant', 'schedule_type')
+            ->distinct()
+            ->get();
+
+        foreach ($invoiceDataRules as $rule) {
+
+            switch ($rule->schedule_type) {
+                case 'Live':
+                    // Run every minute
+                    \Artisan::call('send:invoice-data-report', [
+                        'schedule_type' => $rule->schedule_type,
+                        'plant' => $rule->plant,
+                    ]);
+                    break;
+                case 'Hourly':
+                    if (now()->minute == 0) {
+                        \Artisan::call('send:invoice-data-report', [
+                            'schedule_type' => $rule->schedule_type,
+                            'plant' => $rule->plant,
+                        ]);
+                    }
+                    break;
+                case 'Daily':
+                    if (now()->format('H:i') == '10:00') {
+                        \Artisan::call('send:invoice-data-report', [
+                            'schedule_type' => $rule->schedule_type,
+                            'plant' => $rule->plant,
+                        ]);
+                    }
+                    break;
+            }
+        }
+    }
+
+
+    /**
+     * Helper to call Artisan commands with parameters.
+     */
+    protected function callArtisanCommand($commandName, $rule)
+    {
+        \Artisan::call($commandName, [
+            'schedule_type' => $rule->schedule_type,
+            'plant' => $rule->plant,
+        ]);
+
+        $this->info("Executed {$commandName} for plant: {$rule->plant}");
+        \Log::info("Executed {$commandName} for plant: {$rule->plant}");
+    }
+}

app/Console/Commands/SendInvoiceReport.php

@@ -2,11 +2,11 @@
 
 namespace App\Console\Commands;
 
+use App\Mail\test;
 use App\Models\InvoiceValidation;
 use App\Models\Plant;
 use Illuminate\Console\Command;
 use Illuminate\Support\Facades\Mail;
-use App\Mail\test;
 
 class SendInvoiceReport extends Command
 {
@@ -16,8 +16,7 @@ class SendInvoiceReport extends Command
      * @var string
      */
     // protected $signature = 'app:send-invoice-report';
-   protected $signature = 'send:invoice-report{schedule_type} {plant}';
-
+    protected $signature = 'send:invoice-report {schedule_type} {plant}';
 
     /**
      * The console command description.
@@ -29,12 +28,10 @@ class SendInvoiceReport extends Command
     /**
      * Execute the console command.
      */
-
-
     public function handle()
     {
         $schedule = $this->argument('schedule_type');
-        //$scheduleType = $this->argument('scheduleType');
+        // $scheduleType = $this->argument('scheduleType');
         $plantIdArg = (int) $this->argument('plant'); // can be 0 for all plants
 
         $mailRules = \App\Models\AlertMailRule::where('module', 'InvoiceValidation')->get()->groupBy('rule_name');
@@ -52,18 +49,14 @@ class SendInvoiceReport extends Command
             : [$plantIdArg];
 
         $no = 1;
-        if (strtolower($schedule) == 'daily')
-        {
+        if (strtolower($schedule) == 'daily') {
             $startDate = now()->subDay()->setTime(8, 0, 0);
             $endDate = now()->setTime(8, 0, 0);
-        }
-        else
-        {
+        } else {
             $startDate = now()->setTime(8, 0, 0);
             $endDate = now()->copy()->addDay()->setTime(8, 0, 0);
         }
-        foreach ($plantIds as $plantId)
-        {
+        foreach ($plantIds as $plantId) {
             $plant = Plant::find($plantId);
             $plantName = $plant ? $plant->name : $plantId;
 
@@ -89,7 +82,7 @@ class SendInvoiceReport extends Command
 
             $scannedInvoiceQuan = InvoiceValidation::where('plant_id', $plantId)
                 ->where('scanned_status', 'Scanned')
-                ->where(function($query) {
+                ->where(function ($query) {
                     $query->whereNull('quantity')
                         ->orWhere('quantity', 0);
                 })
@@ -128,7 +121,7 @@ class SendInvoiceReport extends Command
             $scannedMatInvoiceQuan = InvoiceValidation::where('plant_id', $plantId)
                 ->where('quantity', 1)
                 ->whereNotNull('serial_number')
-                ->where('serial_number','!=', '')
+                ->where('serial_number', '!=', '')
                 ->whereBetween('updated_at', [$startDate, $endDate])
                 ->count();
 
@@ -164,7 +157,7 @@ class SendInvoiceReport extends Command
             $scannedBundleInvoiceQuan = InvoiceValidation::where('plant_id', $plantId)
                 ->where('quantity', '>', 1)
                 ->whereNotNull('serial_number')
-                ->where('serial_number','!=', '')
+                ->where('serial_number', '!=', '')
                 ->whereBetween('updated_at', [$startDate, $endDate])
                 ->count();
 
@@ -193,7 +186,6 @@ class SendInvoiceReport extends Command
             }
         }
 
-
         // Send to MaterialInvoiceMail recipients (material + bundle table)
         if ($mailRules->has('MaterialInvoiceMail')) {
             $emails = $mailRules['MaterialInvoiceMail']->pluck('email')->unique()->toArray();
@@ -212,16 +204,14 @@ class SendInvoiceReport extends Command
 
         // Show preview in console
         $this->info('--- Serial Invoice Table ---');
-        $this->table(['#', 'Plant', 'Total Invoice', 'Scanned Invoice','TotalInvoice Quantity', 'ScannedInvoice Quantity'], $serialTableData);
+        $this->table(['#', 'Plant', 'Total Invoice', 'Scanned Invoice', 'TotalInvoice Quantity', 'ScannedInvoice Quantity'], $serialTableData);
 
         $this->info('--- Material Invoice Table ---');
-        $this->table(['#', 'Plant', 'Total Invoice', 'Scanned Invoice','TotalInvoice Quantity', 'ScannedInvoice Quantity'], $materialTableData);
+        $this->table(['#', 'Plant', 'Total Invoice', 'Scanned Invoice', 'TotalInvoice Quantity', 'ScannedInvoice Quantity'], $materialTableData);
 
         $this->info('--- Bundle Invoice Table ---');
-        $this->table(['#', 'Plant', 'Total Invoice', 'Scanned Invoice','TotalInvoice Quantity', 'ScannedInvoice Quantity'], $bundleTableData);
+        $this->table(['#', 'Plant', 'Total Invoice', 'Scanned Invoice', 'TotalInvoice Quantity', 'ScannedInvoice Quantity'], $bundleTableData);
 
         $this->info($contentVars['wishes'] ?? '');
     }
-
-
 }

app/Filament/Resources/AlertMailRuleResource.php

@@ -70,7 +70,6 @@ class AlertMailRuleResource extends Resource
                     ->label('CC Emails'),
                 Forms\Components\Select::make('schedule_type')
                     ->label('Schedule Type')
-                    ->required()
                     ->options([
                     'Live' => 'Live',
                     'Hourly' => 'Hourly',

app/Filament/Resources/ProcessOrderResource.php

@@ -109,7 +109,6 @@ class ProcessOrderResource extends Resource
                     ->afterStateHydrated(function ($component, $state, Get $get, Set $set) {
                         $itemId = $get('item_id');
                         if ($get('id')) {
-
                             $item = \App\Models\Item::where('id', $itemId)->first()?->description;
                             if ($item) {
                                 $set('item_description', $item);
@@ -123,7 +122,6 @@ class ProcessOrderResource extends Resource
                     ->hidden()
                     ->readOnly(),
                 // ->readOnly(true),
-
                 Forms\Components\TextInput::make('process_order')
                     ->label('Process Order')
                     ->reactive()

routes/console.php

@@ -2,8 +2,6 @@
 
 use Illuminate\Foundation\Inspiring;
 use Illuminate\Support\Facades\Artisan;
-use App\Models\AlertMailRule;
-use Illuminate\Console\Scheduling\Schedule;
 
 
 
@@ -11,87 +9,93 @@ Artisan::command('inspire', function () {
     $this->comment(Inspiring::quote());
 })->purpose('Display an inspiring quote');
 
+
+Artisan::command('auto:scheduler', function () {
+    $this->call('custom:scheduler');
+})->everyMinute();
+
+
 //     Schedule::command('send:invoice-report');
 //   Schedule::command('send:production-report');
 
-app()->booted(function () {
-    $schedule = app(Schedule::class);
+// app()->booted(function () {
+//     $schedule = app(Schedule::class);
 
-    // $schedule->command('report:send-daily-production')->dailyAt('07:59');
-        // Production report scheduling
-        $productionRules = AlertMailRule::where('module', 'ProductionQuantities')
-            ->where('rule_name', 'ProductionMail')
-            ->select('plant', 'schedule_type')
-            ->distinct()
-            ->get();
+//     // $schedule->command('report:send-daily-production')->dailyAt('07:59');
+//         // Production report scheduling
+//         $productionRules = AlertMailRule::where('module', 'ProductionQuantities')
+//             ->where('rule_name', 'ProductionMail')
+//             ->select('plant', 'schedule_type')
+//             ->distinct()
+//             ->get();
 
-        foreach ($productionRules as $rule) {
-            $type = $rule->schedule_type;
-            $plantId = $rule->plant;
+//         foreach ($productionRules as $rule) {
+//             $type = $rule->schedule_type;
+//             $plantId = $rule->plant;
 
-            $command = $schedule->command('send:production-report', [$type, $plantId]);
-            // ->appendOutputTo(storage_path('logs/scheduler.log'));
+//             $command = $schedule->command('send:production-report', [$type, $plantId]);
+//             // ->appendOutputTo(storage_path('logs/scheduler.log'));
 
-            switch ($type) {
-                case 'Live':
-                    $command->everyMinute();
-                    break;
-                case 'Hourly':
-                    $command->hourly();
-                    break;
-                case 'Daily':
-                    $command->dailyAt('07:59');
-                    break;
-            }
-        }
+//             switch ($type) {
+//                 case 'Live':
+//                     $command->everyMinute();
+//                     break;
+//                 case 'Hourly':
+//                     $command->hourly();
+//                     break;
+//                 case 'Daily':
+//                     $command->dailyAt('07:59');
+//                     break;
+//             }
+//         }
 
-        // Invoice report scheduling
-        $invoiceRules = AlertMailRule::where('module', 'InvoiceValidation')
-            ->select('plant', 'schedule_type')
-            ->distinct()
-            ->get();
+//         // Invoice report scheduling
+//         $invoiceRules = AlertMailRule::where('module', 'InvoiceValidation')
+//             ->select('plant', 'schedule_type')
+//             ->distinct()
+//             ->get();
 
-        foreach ($invoiceRules as $rule) {
-            $type = $rule->schedule_type;
-            $plantId = $rule->plant;
+//         foreach ($invoiceRules as $rule) {
+//             $type = $rule->schedule_type;
+//             $plantId = $rule->plant;
 
-            $command = $schedule->command('send:invoice-report', [$type, $plantId]);
+//             $command = $schedule->command('send:invoice-report', [$type, $plantId]);
 
-            switch ($type) {
-                case 'Live':
-                    $command->everyMinute();
-                    break;
-                case 'Hourly':
-                    $command->hourly();
-                    break;
-                case 'Daily':
-                    $command->dailyAt('07:59');
-                    break;
-            }
-        }
+//             switch ($type) {
+//                 case 'Live':
+//                     $command->everyMinute();
+//                     break;
+//                 case 'Hourly':
+//                     $command->hourly();
+//                     break;
+//                 case 'Daily':
+//                     $command->dailyAt('07:59');
+//                     break;
+//             }
+//         }
 
-        // Invoice Data Report Scheduling
-        $invoiceDataRules = AlertMailRule::where('module', 'InvoiceDataReport')
-            ->select('plant', 'schedule_type')
-            ->distinct()
-            ->get();
+//         // Invoice Data Report Scheduling
+//         $invoiceDataRules = AlertMailRule::where('module', 'InvoiceDataReport')
+//             ->select('plant', 'schedule_type')
+//             ->distinct()
+//             ->get();
 
-        foreach ($invoiceDataRules as $rule) {
-            $type = $rule->schedule_type;
-            $plantId = $rule->plant;
+//         foreach ($invoiceDataRules as $rule) {
+//             $type = $rule->schedule_type;
+//             $plantId = $rule->plant;
 
-            $command = $schedule->command('send:invoice-data-report', [$type, $plantId]);
+//             $command = $schedule->command('send:invoice-data-report', [$type, $plantId]);
 
-            switch ($type) {
-                case 'Live':
-                    $command->everyMinute();
-                    break;
-                case 'Hourly':
-                    $command->hourly();
-                    break;
-                case 'Daily':
-                    $command->dailyAt('10:00');
-                    break;
-            }
-        }
-});
+//             switch ($type) {
+//                 case 'Live':
+//                     $command->everyMinute();
+//                     break;
+//                 case 'Hourly':
+//                     $command->hourly();
+//                     break;
+//                 case 'Daily':
+//                     $command->dailyAt('10:00');
+//                     break;
+//             }
+//         }
+// });