Refactored ProcessOrderImporter to standardize column headers and improve error messaging
Some checks failed
Scan for leaked secrets using Kingfisher / kingfisher-secrets-scan (push) Successful in 10s
Scan for leaked secrets using Kingfisher / kingfisher-secrets-scan (pull_request) Successful in 11s
Gemini PR Review / review (pull_request) Failing after 23s
Laravel Larastan / larastan (pull_request) Failing after 2m3s
Laravel Pint / pint (pull_request) Failing after 2m14s

This commit is contained in:
dhanabalan
2025-11-26 19:42:46 +05:30
parent c64fbf209e
commit 73d863b200

View File

@@ -6,11 +6,11 @@ use App\Models\Item;
use App\Models\Plant;
use App\Models\ProcessOrder;
use App\Models\User;
use Filament\Actions\Imports\Exceptions\RowImportFailedException;
use Filament\Actions\Imports\ImportColumn;
use Filament\Actions\Imports\Importer;
use Filament\Actions\Imports\Models\Import;
use Str;
use Filament\Actions\Imports\Exceptions\RowImportFailedException;
class ProcessOrderImporter extends Importer
{
@@ -21,27 +21,28 @@ class ProcessOrderImporter extends Importer
return [
ImportColumn::make('plant')
->requiredMapping()
->exampleHeader('Plant Code')
->exampleHeader('PLANT CODE')
->example('1000')
->label('Plant Code')
->label('PLANT CODE')
->relationship(resolveUsing: 'code')
->rules(['required']),
ImportColumn::make('item')
->requiredMapping()
->exampleHeader('Item Code')
->exampleHeader('ITEM CODE')
->example('123456')
->label('Item Code')
->label('ITEM CODE')
->relationship(resolveUsing: 'code')
->rules(['required']),
ImportColumn::make('process_order')
->exampleHeader('Process Order')
->example('200000166843')
->label('Process Order')
->exampleHeader('PROCESS ORDER')
->example('202500123456')
->label('PROCESS ORDER')
->rules(['required']),
ImportColumn::make('created_by')
->exampleHeader('Created By')
->exampleHeader('CREATED BY')
->example('RAW01234')
->label('Created By'),
->label('CREATED BY')
->rules(['required']),
];
}
@@ -53,25 +54,22 @@ class ProcessOrderImporter extends Importer
$iCode = trim($this->data['item']);
if (! $plant) {
$warnMsg[] = "Plant not found";
}
else if (Str::length($iCode) < 6 || !ctype_alnum($iCode)) {
$warnMsg[] = "Invalid item code found";
}
else if(!$itemCode)
{
$warnMsg[] = "Item Code not found";
$warnMsg[] = 'Plant not found';
} elseif (Str::length($iCode) < 6 || ! ctype_alnum($iCode)) {
$warnMsg[] = 'Invalid item code found';
} elseif (! $itemCode) {
$warnMsg[] = 'Item Code not found';
}
$processOrder = trim($this->data['process_order'] ?? '');
if ($processOrder == '') {
$warnMsg[] = "Process Order cannot be empty";
$warnMsg[] = 'Process Order cannot be empty';
}
$user = User::where('name', $this->data['created_by'])->first();
if (! $user) {
$warnMsg[] = "User not found";
$warnMsg[] = 'User not found';
}
if ($plant && $processOrder != '') {
@@ -81,7 +79,7 @@ class ProcessOrderImporter extends Importer
->first();
if ($existingOrder && $existingOrder->item_id !== ($itemCode->id ?? null)) {
$warnMsg[] = "Same Process Order already exists for this Plant with a different Item Code";
$warnMsg[] = 'Same Process Order already exists for this Plant with a different Item Code';
}
}
@@ -93,7 +91,7 @@ class ProcessOrderImporter extends Importer
'plant_id' => $plant->id,
'item_id' => $itemCode->id,
'process_order' => trim($this->data['process_order']),
'coil_number' => "0",
'coil_number' => '0',
'order_quantity' => 0,
'received_quantity' => 0,
'created_by' => $user->name,