Refactor duplicate QR code messages for consistency in wording and clarity

This commit is contained in:
dhanabalan
2025-11-08 16:20:00 +05:30
parent b25b42083f
commit 317e877255

View File

@@ -223,7 +223,7 @@ class InvoiceOutValidationResource extends Resource
$uniqueKey = $plantCode . '_' . $qrCode; $uniqueKey = $plantCode . '_' . $qrCode;
if (in_array($uniqueKey, $seenPlantQr)) { if (in_array($uniqueKey, $seenPlantQr)) {
$duplicateQrExcel[] = "Duplicate in file at Row {$index}: Document Numbers '{$qrCode}' already exists for Plant Code '{$plant->name}'"; $duplicateQrExcel[] = "Duplicate in file at Row {$index}: Document Number '{$qrCode}' already exists for Plant '{$plant->name}'";
} }
$seenPlantQr[] = $uniqueKey; $seenPlantQr[] = $uniqueKey;
@@ -233,7 +233,7 @@ class InvoiceOutValidationResource extends Resource
// ->first(); // ->first();
// if ($existsInDb) { // if ($existsInDb) {
// $duplicateQrDb[] = "Document Numbers '{$qrCode}' already exists in DB for Plant Code {$plant->name}"; // $duplicateQrDb[] = "Document Numbers '{$qrCode}' already exists in DB for Plant '{$plant->name}'";
// } // }
} }
@@ -301,7 +301,7 @@ class InvoiceOutValidationResource extends Resource
$duplicateGroupedByPlantQr = []; $duplicateGroupedByPlantQr = [];
foreach ($duplicateQrExcel as $message) {//"/Document Numbers '([^']+)' already exists for Plant Code (\S+)/" foreach ($duplicateQrExcel as $message) {//"/Document Numbers '([^']+)' already exists for Plant Code (\S+)/"
if (preg_match("/Document Numbers '([^']+)' already exists for Plant Code '([^']+)'/", $message, $matches)) { if (preg_match("/Document Number '([^']+)' already exists for Plant '([^']+)'/", $message, $matches)) {
$qrCode = $matches[1]; $qrCode = $matches[1];
$plantCode = $matches[2]; $plantCode = $matches[2];
$duplicateGroupedByPlantQr[$plantCode][] = $qrCode; $duplicateGroupedByPlantQr[$plantCode][] = $qrCode;
@@ -340,7 +340,7 @@ class InvoiceOutValidationResource extends Resource
// $duplicateGroupedByPlantDb = []; // $duplicateGroupedByPlantDb = [];
// foreach ($duplicateQrDb as $message) { // foreach ($duplicateQrDb as $message) {
// if (preg_match("/Document Numbers '([^']+)' already exists in DB for Plant Code (\S+)/", $message, $matches)) { // if (preg_match("/Document Numbers '([^']+)' already exists in DB for Plant '([^']+)'/", $message, $matches)) {
// $qrCode = $matches[1]; // $qrCode = $matches[1];
// $plantCode = $matches[2]; // $plantCode = $matches[2];
// $duplicateGroupedByPlantDb[$plantCode][] = $qrCode; // $duplicateGroupedByPlantDb[$plantCode][] = $qrCode;