From 484bc6d0706e1edf79e0b55cdd0a5e06e2b52dc5 Mon Sep 17 00:00:00 2001 From: dhanabalan Date: Fri, 11 Jul 2025 16:01:37 +0530 Subject: [PATCH] Added proper status code for all the api modules --- app/Http/Controllers/ModuleChartController.php | 6 +++--- app/Http/Controllers/ModuleController.php | 4 ++-- app/Http/Controllers/ModuleFilterController.php | 2 +- app/Http/Controllers/ModuleFilterDataController.php | 10 +++++----- app/Http/Controllers/ModulePlantController.php | 6 +++--- app/Http/Controllers/ModulePlantLineController.php | 2 +- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/app/Http/Controllers/ModuleChartController.php b/app/Http/Controllers/ModuleChartController.php index b860e084a..e8b9021c4 100644 --- a/app/Http/Controllers/ModuleChartController.php +++ b/app/Http/Controllers/ModuleChartController.php @@ -38,7 +38,7 @@ class ModuleChartController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => "Module Name can't be empty!" - ], 400); + ], 404); } $exists = ModuleList::where('module_name', $moduleName)->exists(); @@ -62,10 +62,10 @@ class ModuleChartController extends Controller ->values(); // reset array keys - return response()->json([ + return response()->json([ 'status_code' => 'SUCCESS', 'status_description' => $dashboardNames - ]); + ], 200); } diff --git a/app/Http/Controllers/ModuleController.php b/app/Http/Controllers/ModuleController.php index f766e1eab..1adebac49 100644 --- a/app/Http/Controllers/ModuleController.php +++ b/app/Http/Controllers/ModuleController.php @@ -54,7 +54,7 @@ class ModuleController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => "Module Name can't be empty!" - ], 400); + ], 404); } $headerValue = $request->header('module-name'); @@ -63,7 +63,7 @@ class ModuleController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => "Invalid value for 'module-name' header!" - ], 400); + ], 404); } $uniqueModules = ModuleList::select('module_name', 'created_at') diff --git a/app/Http/Controllers/ModuleFilterController.php b/app/Http/Controllers/ModuleFilterController.php index 6a3bf00dc..8f23ac554 100644 --- a/app/Http/Controllers/ModuleFilterController.php +++ b/app/Http/Controllers/ModuleFilterController.php @@ -38,7 +38,7 @@ class ModuleFilterController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => "Line name can't be empty!" - ], 400); + ], 404); } $filterNames = ModuleList::orderBy('created_at', 'asc') diff --git a/app/Http/Controllers/ModuleFilterDataController.php b/app/Http/Controllers/ModuleFilterDataController.php index 27feaab84..f0415ad70 100644 --- a/app/Http/Controllers/ModuleFilterDataController.php +++ b/app/Http/Controllers/ModuleFilterDataController.php @@ -145,7 +145,7 @@ class ModuleFilterDataController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => 'Missing required headers: ' . implode(', ', $missingHeaders) - ], 400); + ], 404); } $validFilters = ['Today', 'Yesterday', 'This Week', 'This Month']; @@ -155,7 +155,7 @@ class ModuleFilterDataController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => "Invalid filter-name value! Accepted values are: " . implode(', ', $validFilters) - ], 400); + ], 404); } $plantName = $request->header('plant-name'); @@ -171,13 +171,13 @@ class ModuleFilterDataController extends Controller } // Set date filter range - if ($filterName === 'yesterday') { + if ($filterName == 'yesterday') { $startDate = now()->subDay()->setTime(8, 0, 0); $endDate = now()->setTime(8, 0, 0); - } elseif ($filterName === 'this week') { + } elseif ($filterName == 'this week') { $startDate = now()->startOfWeek()->setTime(8, 0, 0); $endDate = now()->endOfWeek()->addDay()->setTime(8, 0, 0); - } elseif ($filterName === 'this month') { + } elseif ($filterName == 'this month') { $startDate = now()->startOfMonth(); $endDate = now()->endOfMonth(); } else { diff --git a/app/Http/Controllers/ModulePlantController.php b/app/Http/Controllers/ModulePlantController.php index 5acaaf951..b4f8c3052 100644 --- a/app/Http/Controllers/ModulePlantController.php +++ b/app/Http/Controllers/ModulePlantController.php @@ -38,7 +38,7 @@ class ModulePlantController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => "Plant Name can't be empty!" - ], 400); + ], 404); } $headerValue = $request->header('plant-name'); @@ -47,7 +47,7 @@ class ModulePlantController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => "Invalid value for 'plant-name' header!" - ], 400); + ], 404); } $plantNames = Plant::orderBy('created_at', 'asc') @@ -57,7 +57,7 @@ class ModulePlantController extends Controller return response()->json([ 'status_code' => 'SUCCESS', 'status_description' => $plantNames - ]); + ], 200); } /** diff --git a/app/Http/Controllers/ModulePlantLineController.php b/app/Http/Controllers/ModulePlantLineController.php index ccea0c4a4..bda6b8add 100644 --- a/app/Http/Controllers/ModulePlantLineController.php +++ b/app/Http/Controllers/ModulePlantLineController.php @@ -39,7 +39,7 @@ class ModulePlantLineController extends Controller return response()->json([ 'status_code' => 'ERROR', 'status_description' => "Plant Name can't be empty!" - ], 400); + ], 404); } $plant = Plant::where('name', $plantName)->first();